ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1916789379
##########
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##########
@@ -133,4 +134,27 @@ private static Collection<PartitionStats> mergeStats(
return statsMap.values();
}
+
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ public static boolean isEqual(
+ Comparator<StructLike> partitionComparator, PartitionStats stats1,
PartitionStats stats2) {
Review Comment:
Cannot have `Equals` and `HashCode` for `PartitionStats` class as
`StructLike` need to have comparator for `equals()` which forces that class
extends `StructLike` to hold some more things. Setting comparator while
serializing and deserializing that class will be a mess.
Hence, added this util method. Currently used only by tests. But can be
useful for developers when they integrate partition stats to engines, they can
use it for their tests. So, kept as a util.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
