amogh-jahagirdar commented on code in PR #12135:
URL: https://github.com/apache/iceberg/pull/12135#discussion_r1935947512
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -142,15 +185,43 @@ public void testUnpartitionedTable() throws Exception {
TestHelpers.nonDerivedSchema(actualFilesDs), expectedFiles.get(1),
actualFiles.get(1));
}
+ @TestTemplate
+ public void testPositionDeletesTable() throws Exception {
+ sql(
+ "CREATE TABLE %s (id bigint, data string) USING iceberg TBLPROPERTIES"
+ + "('format-version'='%s', 'write.delete.mode'='merge-on-read')",
+ tableName, formatVersion);
+
+ List<SimpleRecord> records =
+ Lists.newArrayList(
+ new SimpleRecord(1, "a"),
+ new SimpleRecord(2, "b"),
+ new SimpleRecord(3, "c"),
+ new SimpleRecord(4, "d"));
+ spark
+ .createDataset(records, Encoders.bean(SimpleRecord.class))
+ .coalesce(1)
+ .writeTo(tableName)
+ .append();
+
+ sql("DELETE FROM %s WHERE id=1 OR id=3", tableName);
+
+ // check delete files table
+ assertThat(sql("SELECT * FROM %s.delete_files", tableName)).hasSize(1);
+
+ // check position_deletes table
+ assertThat(sql("SELECT * FROM %s.position_deletes", tableName)).hasSize(2);
Review Comment:
Should we assert the contents of the rows? I can see how it's a bit of a
pain between v2/v3 but feels like a stronger assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
