nastra commented on code in PR #12135:
URL: https://github.com/apache/iceberg/pull/12135#discussion_r1935377367
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -62,6 +67,44 @@
@ExtendWith(ParameterizedTestExtension.class)
public class TestMetadataTables extends ExtensionsTestBase {
+ @Parameter(index = 3)
+ private int formatVersion;
+
+ @Parameters(name = "catalogName = {0}, implementation = {1}, config = {2},
formatVersion = {3}")
+ protected static Object[][] parameters() {
Review Comment:
as defined in `CatalogTestBase` the default catalogs that were previously
tested were Hadoop/Hive/Spark/REST. I'm limiting this here to Spark + REST,
since we're adding testing for format version 2 + 3 here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
