nastra commented on code in PR #12133:
URL: https://github.com/apache/iceberg/pull/12133#discussion_r1935618451
##########
core/src/test/java/org/apache/iceberg/actions/TestSizeBasedRewriter.java:
##########
@@ -76,6 +76,27 @@ public void testSplitSizeLowerBound() {
assertThat(splitSize).isLessThan(maxFileSize);
}
+ @TestTemplate
+ public void testDeleteFileThresholdOption() {
+ SizeBasedDataFileRewriterImpl rewriter = new
SizeBasedDataFileRewriterImpl(table);
+
+ Map<String, String> options = ImmutableMap.of(
+ SizeBasedDataRewriter.DELETE_FILE_THRESHOLD, "5"
Review Comment:
`DELETE_FILE_THRESHOLD` is different from the delete ratio and is for
something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
