nastra commented on code in PR #12133:
URL: https://github.com/apache/iceberg/pull/12133#discussion_r1935616754
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java:
##########
@@ -67,6 +68,8 @@ public Set<String> validOptions() {
public void init(Map<String, String> options) {
super.init(options);
this.deleteFileThreshold = deleteFileThreshold(options);
+ this.deleteRatioThreshold = PropertyUtil.propertyAsDouble(
+ options, "delete-ratio-threshold", DEFAULT_DELETE_THRESHOLD);
Review Comment:
`delete-ratio-threshold` should be a static final (similar to
`DELETE_FILE_THRESHOLD`) and have a proper javadoc documentation so that it's
clear what this parameter is used for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
