nastra commented on code in PR #12133:
URL: https://github.com/apache/iceberg/pull/12133#discussion_r1935612987
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java:
##########
@@ -67,6 +68,8 @@ public Set<String> validOptions() {
public void init(Map<String, String> options) {
super.init(options);
this.deleteFileThreshold = deleteFileThreshold(options);
+ this.deleteRatioThreshold = PropertyUtil.propertyAsDouble(
Review Comment:
we also need to validate that `0.0 > threshold <= 1.0`. That would also
require some additional unit tests that check for valid/invalid parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
