rdblue opened a new pull request, #12102: URL: https://github.com/apache/iceberg/pull/12102
This is a refactor that cleans up a few issues I noticed while reviewing #11904 and while working on Parquet variant readers. - Updates INT and UINT handling to reject unsupported unsigned types (like UINT64) - Adds more factory methods to `ParquetValueReaders` to keep implementations private - Removes unused `types` argument from `ParquetValueReader.StructReader` subclasses. Some accessible uses had to be left, but most are removed. This allowed removing types from the reader builders as well. - Removes unnecessary `TimeUnit` param from factory methods added in #11904 - Removes unnecessary implementations of `setPageSource` - Adds imports for `LogicalTypeAnnotation` classes to cut down on multi-line method signatures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
