amogh-jahagirdar commented on code in PR #11839:
URL: https://github.com/apache/iceberg/pull/11839#discussion_r1925929783
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##########
@@ -199,6 +204,222 @@ public void testTwoLevelList() throws IOException {
}
}
+ @Test
+ public void testMissingRequiredWithoutDefault() {
Review Comment:
Ah yeah, a while ago I think @jbonofre and I were talking and I pointed to
the Spark PR for examples of tests for default values but it seems like it got
later refactored to move those to `DataTest` to avoid duplication
@jbonofre I think all we'd need to do here is just override
supportsDefaultValues to just return true since it doesn't seem like there are
new tests/differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
