rdblue commented on code in PR #11839:
URL: https://github.com/apache/iceberg/pull/11839#discussion_r1925832926
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##########
@@ -199,6 +204,222 @@ public void testTwoLevelList() throws IOException {
}
}
+ @Test
+ public void testMissingRequiredWithoutDefault() {
Review Comment:
The other tests added `supportsDefaultValues` and the new cases to
[`DataTest`](https://github.com/apache/iceberg/blob/main/data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java#L99-L102),
which I think this inherits from. Why not use the same test cases? Were there
changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
