jbonofre commented on code in PR #11839:
URL: https://github.com/apache/iceberg/pull/11839#discussion_r1927283203
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java:
##########
@@ -236,4 +457,44 @@ protected void writeAndValidate(Schema schema) throws
IOException {
RandomGenericData.generateFallbackRecords(schema, NUM_RECORDS, 21124,
NUM_RECORDS / 20),
schema);
}
+
+ @Override
+ protected void writeAndValidate(Schema writeSchema, Schema expectedSchema)
throws IOException {
+ assumeThat(
+ TypeUtil.find(
+ writeSchema,
+ type -> type.isMapType() && type.asMapType().keyType() !=
Types.StringType.get()))
+ .as("Parquet Avro cannot write non-string map keys")
+ .isNull();
Review Comment:
I updated the private method to support `expectedSchema` (optionally) and
compare with this schema when provided. Thanks to that, the private
`writeAndValidate()` is used in `writeAndValidate(writeSchema, expectedSchema)`
(for default values).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
