rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1924346731
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -63,6 +69,18 @@ public static ParquetValueReader<Long> position() {
return new PositionReader();
}
+ public static ParquetValueReader<UUID> uuids(ColumnDescriptor desc) {
+ return new ParquetValueReaders.UUIDReader(desc);
+ }
+
+ public static ParquetValueReader<Long> timestampInt96Reader(ColumnDescriptor
desc) {
+ return new ParquetValueReaders.TimestampInt96Reader(desc);
+ }
+
+ public static ParquetValueReader<Long>
timestampMillisReader(ColumnDescriptor desc) {
Review Comment:
I'd probably rename this as well, maybe `millisAsTimestamps` or
`millisecondTimestamps`
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -63,6 +69,18 @@ public static ParquetValueReader<Long> position() {
return new PositionReader();
}
+ public static ParquetValueReader<UUID> uuids(ColumnDescriptor desc) {
+ return new ParquetValueReaders.UUIDReader(desc);
+ }
+
+ public static ParquetValueReader<Long> timestampInt96Reader(ColumnDescriptor
desc) {
+ return new ParquetValueReaders.TimestampInt96Reader(desc);
+ }
+
+ public static ParquetValueReader<Long>
timestampMillisReader(ColumnDescriptor desc) {
Review Comment:
I'd probably rename this as well, maybe `millisAsTimestamps`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
