ajantha-bhat commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1920247487
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetWriter.java:
##########
@@ -50,6 +42,27 @@ protected ParquetValueWriter<T> createWriter(MessageType
type) {
protected abstract ParquetValueWriters.StructWriter<T> createStructWriter(
List<ParquetValueWriter<?>> writers);
+ protected ParquetValueWriters.PrimitiveWriter<?>
fixedWriter(ColumnDescriptor desc) {
+ return ParquetValueWriters.fixed(desc);
+ }
+
+ protected Optional<ParquetValueWriters.PrimitiveWriter<?>>
dateWriter(ColumnDescriptor desc) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueWriters.PrimitiveWriter<?>>
timeWriter(ColumnDescriptor desc) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueWriters.PrimitiveWriter<?>> timestampWriter(
+ ColumnDescriptor desc, boolean isAdjustedToUTC) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueWriters.PrimitiveWriter<?>>
uuidWriter(ColumnDescriptor desc) {
Review Comment:
CI just failed for ArrowReaderTest > testReadAll().
Generic writer expects byte[] based UUID handling and internal reader and
writer works directly on UUID object. So, we do need a factory method here as
we need to supply different kinds of UUID representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
