ajantha-bhat commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1920166221
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -76,6 +67,31 @@ protected ParquetValueReader<T> createReader(
protected abstract ParquetValueReader<T> createStructReader(
List<Type> types, List<ParquetValueReader<?>> fieldReaders,
Types.StructType structType);
+ protected ParquetValueReaders.PrimitiveReader<?>
fixedReader(ColumnDescriptor desc) {
+ return null;
+ }
+
+ protected ParquetValueReaders.PrimitiveReader<?>
int96Reader(ColumnDescriptor desc) {
+ return null;
+ }
+
+ protected Optional<ParquetValueReader<?>> dateReader(ColumnDescriptor desc) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueReader<?>> timeReader(ColumnDescriptor desc,
TimeUnit unit) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueReader<?>> timestampReader(
+ ColumnDescriptor desc, TimeUnit unit, boolean isAdjustedToUTC) {
+ return Optional.empty();
+ }
+
+ protected Optional<ParquetValueReader<?>> uuidReader(ColumnDescriptor desc) {
Review Comment:
CI just failed for `ArrowReaderTest > testReadAll()`.
Generic reader and writer expects byte[] based UUID handling and internal
reader and writer works directly on UUID object. So, we do need a factory
method here as we need to supply different kinds of UUID representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
