smaheshwar-pltr commented on PR #1452: URL: https://github.com/apache/iceberg-python/pull/1452#issuecomment-2581158650
> This matches the behavior of the [Java implementation](https://iceberg.apache.org/docs/nightly/custom-catalog/#custom-location-provider-implementation). However, if we're reusing the same property (write.location-provider.impl), then there's a conflict when loading in both Java and Python. I wonder if we should add a python specific property, otherwise location-provider will only work in one of the implementations and might error in the other. Great point! I've made the change to `WRITE_PY_LOCATION_PROVIDER_IMPL = "write.py-location-provider.impl"` (happy to take suggestions) - inspired by `io-impl` $\to$ `py-io-impl`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
