smaheshwar-pltr commented on code in PR #1452:
URL: https://github.com/apache/iceberg-python/pull/1452#discussion_r1909356132
##########
tests/integration/test_writes/test_partitioned_writes.py:
##########
@@ -280,6 +280,43 @@ def test_query_filter_v1_v2_append_null(
assert df.where(f"{col} is null").count() == 2, f"Expected 2 null rows
for {col}"
+@pytest.mark.integration
+@pytest.mark.parametrize(
+ "part_col", ["int", "bool", "string", "string_long", "long", "float",
"double", "date", "timestamp", "timestamptz", "binary"]
+)
+@pytest.mark.parametrize("format_version", [1, 2])
+def test_object_storage_excludes_partition(
+ session_catalog: Catalog, spark: SparkSession, arrow_table_with_null:
pa.Table, part_col: str, format_version: int
+) -> None:
+ nested_field = TABLE_SCHEMA.find_field(part_col)
+ partition_spec = PartitionSpec(
+ PartitionField(source_id=nested_field.field_id, field_id=1001,
transform=IdentityTransform(), name=part_col)
+ )
+
+ tbl = _create_table(
+ session_catalog=session_catalog,
+
identifier=f"default.arrow_table_v{format_version}_with_null_partitioned_on_col_{part_col}",
+ properties={"format-version": str(format_version),
"write.object-storage.enabled": True},
Review Comment:
Now that it's the default, I removed it here (and added a comment for both
defaults), so there's one integration test that checks not specifying it. I
used the constants in all other places in the integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
