smaheshwar-pltr commented on code in PR #1452:
URL: https://github.com/apache/iceberg-python/pull/1452#discussion_r1909339914
##########
pyiceberg/io/pyarrow.py:
##########
@@ -2234,7 +2235,9 @@ def data_file_statistics_from_parquet_metadata(
)
-def write_file(io: FileIO, table_metadata: TableMetadata, tasks:
Iterator[WriteTask]) -> Iterator[DataFile]:
+def write_file(
+ io: FileIO, location_provider: LocationProvider, table_metadata:
TableMetadata, tasks: Iterator[WriteTask]
+) -> Iterator[DataFile]:
from pyiceberg.table import DOWNCAST_NS_TIMESTAMP_TO_US_ON_WRITE,
TableProperties
Review Comment:
WDYT about leaving the signature as before and doing
`load_location_provider` at the start of this function (above
`parquet_writer_kwargs = _get_parquet_writer_kwargs(table_metadata.properties)`
instead of in `_dataframe_to_data_files`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
