rdblue commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1907672639


##########
format/spec.md:
##########
@@ -1480,6 +1494,9 @@ This serialization scheme is for storing single values as 
individual binary valu
 | **`struct`**                 | Not supported                                 
                                                               |
 | **`list`**                   | Not supported                                 
                                                               |
 | **`map`**                    | Not supported                                 
                                                               |
+| **`geometry`**               | A single point, encoded as a {x, y, optional 
z, optional m} concatenation of its 8-byte little-endian IEEE 754 coordinate 
values, with the optional coordinates encoded as NaN if unset. |

Review Comment:
   I don't think this table is the right place to define this encoding because 
this covers any value and the encoding for arbitrary geometry and geography 
values is WKB.
   
   For the lower and upper bounds, I suggest adding a new section and 
documenting the way we store points specifically for both types.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to