rdblue commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1907648464
##########
format/spec.md:
##########
@@ -205,13 +205,18 @@ Supported primitive types are defined in the table below.
Primitive types added
| | **`uuid`** | Universally unique identifiers
| Should use 16-byte fixed
|
| | **`fixed(L)`** | Fixed-length byte array of length L
|
|
| | **`binary`** | Arbitrary-length byte array
|
|
+| [v3](#version-3) | **`geometry(C)`** | Geometry features from [OGC – Simple
feature access](https://portal.ogc.org/files/?artifact_id=25355). Edges
interpolation is always linear/planar. See [Appendix
G](#appendix-g-geospatial-notes). Parameterized by crs C [4]. If not specified,
C is `OGC:CRS84`. | |
+| [v3](#version-3) | **`geography(C, A)`** | Geometry features from [OGC –
Simple feature access](https://portal.ogc.org/files/?artifact_id=25355). See
[Appendix G](#appendix-g-geospatial-notes). Parameterized by crs C[5] and
edge-interpolation algoritm A [6]. If not specified, C is `OGC:CRS84`. |
|
Review Comment:
Nits:
- Duplicated URL can be moved into a
[reference](https://www.markdownguide.org/basic-syntax/#formatting-the-second-part-of-the-link)
using `[OGC - Simple feature access][label]`
- Missing a space between `C` and `[5]`
- It would be good to add the list of algorithms after the table and before
notes, rather than in the appendix. Those algorithm definitions are part of the
spec, right?
- "crs" (lower case) is used here, but "CRS" is used in the note that
defines CRS. I think it should be upper case everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
