rdblue commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1907668388
########## format/spec.md: ########## @@ -1239,6 +1247,9 @@ When reading an `unknown` column, any corresponding column must be ignored and r | **`struct`** | `struct` | | | | **`list`** | `array` | | | | **`map`** | `map` | | | +| **`geometry`** | `binary` | | WKB format, see [Appendix G](#appendix-g-geospatial-notes). | +| **`geography`** | `binary` | | WKB format, see [Appendix G](#appendix-g-geospatial-notes). | Review Comment: I think that ORC will require a type attribute like `uuid` and `fixed`. Looks like it should be `iceberg.binary-type` = `GEOMETRY` and `GEOGRAPHY`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org