rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1906125908
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -359,10 +250,10 @@ public ParquetValueReader<?> primitive(
ColumnDescriptor desc = type.getColumnDescription(currentPath());
- if (primitive.getOriginalType() != null) {
+ if (primitive.getLogicalTypeAnnotation() != null) {
Review Comment:
I agree with this change, but please point these kinds of changes out for
reviewers.
The old version worked because all of the supported logical type annotations
had an equivalent `ConvertedType` (which is what `OriginalType` is called in
Parquet format and the [logical type
docs](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#numeric-types)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
