rdblue commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1906068027
########## parquet/src/main/java/org/apache/iceberg/data/parquet/InternalWriter.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.data.parquet; + +import java.util.List; +import java.util.Optional; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.parquet.ParquetValueWriter; +import org.apache.iceberg.parquet.ParquetValueWriters; +import org.apache.iceberg.parquet.ParquetValueWriters.StructWriter; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.types.Type; +import org.apache.parquet.column.ColumnDescriptor; +import org.apache.parquet.schema.LogicalTypeAnnotation; +import org.apache.parquet.schema.MessageType; + +/** + * A Writer that consumes Iceberg's internal in-memory object model. + * + * <p>Iceberg's internal in-memory object model produces the types defined in {@link + * Type.TypeID#javaClass()}. + */ +public class InternalWriter extends BaseParquetWriter<StructLike> { + private static final InternalWriter INSTANCE = new InternalWriter(); + + private InternalWriter() {} + + public static ParquetValueWriter<StructLike> buildWriter(MessageType type) { + return INSTANCE.createWriter(type); + } + + @Override + protected StructWriter<StructLike> createStructWriter(List<ParquetValueWriter<?>> writers) { + return new ParquetStructWriter(writers); + } + + @Override + protected LogicalTypeAnnotation.LogicalTypeAnnotationVisitor< + ParquetValueWriters.PrimitiveWriter<?>> + logicalTypeWriterVisitor(ColumnDescriptor desc) { + return new LogicalTypeWriterVisitor(desc); + } + + @Override + protected ParquetValueWriters.PrimitiveWriter<?> fixedWriter(ColumnDescriptor desc) { + // accepts ByteBuffer and internally writes as binary. + return ParquetValueWriters.byteBuffers(desc); Review Comment: Make sure this writer checks the length of the incoming bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
