liurenjie1024 commented on code in PR #795:
URL: https://github.com/apache/iceberg-rust/pull/795#discussion_r1899878300
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -2728,22 +2730,24 @@ mod _serde {
optional: _,
}) => match ty {
Type::Struct(struct_ty) => {
- let iters: Vec<Option<Literal>> = required
- .into_iter()
- .map(|(field_name, value)| {
- let field = struct_ty
- .field_by_name(field_name.as_str())
- .ok_or_else(|| {
- invalid_err_with_reason(
- "record",
- &format!("field {} is not exist",
&field_name),
- )
- })?;
- let value = value.try_into(&field.field_type)?;
- Ok(value)
+ let mut value_map: HashMap<String, RawLiteralEnum> =
Review Comment:
I don't quite understand why we ignore `optional` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
