Re: [PR] fix: gurantee the deserialize order of struct is same as the struct type [iceberg-rust]

[via GitHub]

Xuanwo commented on code in PR #795:
URL: https://github.com/apache/iceberg-rust/pull/795#discussion_r1884848752


##########
crates/iceberg/src/spec/values.rs:
##########
@@ -3439,11 +3443,13 @@ mod tests {
                     "bar".to_string(),
                 ))),
                 None,
+                Some(Literal::Primitive(PrimitiveLiteral::Int(1000))),
             ])),
             &Type::Struct(StructType::new(vec![
                 NestedField::required(2, "id", 
Type::Primitive(PrimitiveType::Int)).into(),
                 NestedField::optional(3, "name", 
Type::Primitive(PrimitiveType::String)).into(),
                 NestedField::optional(4, "address", 
Type::Primitive(PrimitiveType::String)).into(),
+                NestedField::required(5, "extra", 
Type::Primitive(PrimitiveType::Int)).into(),

Review Comment:
   Hi, would you like to add a new test that cover the mis-order cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org