jiakai-li commented on code in PR #1453: URL: https://github.com/apache/iceberg-python/pull/1453#discussion_r1896119481
########## tests/io/test_pyarrow.py: ########## Review Comment: Yes, I thought about that as well, essentially I tried to set up another service like `minio-ap-southeast-1`, but found it a bit cumbersome. Do you think we can do more of unit testing to ensure `PyArrowFileIO.fs_by_scheme` returns the correct fs of a region and skip the integration test, or if we would like to investigate more to set up multi-region minio instance and override the endpoint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
