jiakai-li commented on PR #1453:
URL: https://github.com/apache/iceberg-python/pull/1453#issuecomment-2557880783

   Thank you @kevinjqliu , can I have some more guidance on this please?
   
   > Im dont think netloc can be used to determine the region. S3 URI scheme 
doesn't use netloc, only S3 URL does.
   
   I did some search and seems in terms of s3 scheme, the format is 
`s3://<bucket-name>/<key-name>`. The `netloc` parsed from `urlparse` 
(essentially passed to the `_initialize_fs` call) then points to the 
`bucket-name`. Is there an exception that doesn't follow this format?
   
   > BTW a good test scenario can be a table where my metadata files are stored 
in one bucket while my data files are stored in another. We might be able to 
construct this test case by modifying the minio settings to create different 
regional buckets; I haven't tested this yet.
   
   Yep, I tested the change using a similar scenario locally with my own 
handcrafted s3 files. But will add more proper test cases as I make more 
progress. Thanks again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to