sungwy commented on PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#issuecomment-2546756342

   Hi @AhmedNader42 - thank you very much for picking up this issue and getting 
a working solution up already!
   
   I'm in agreement with @kevinjqliu 's comment, that it would be great to have 
an integration test as well, and I think it is well within the scope of this PR.
   
   
https://github.com/apache/iceberg-python/blob/main/tests/integration/test_reads.py
 already uses `session_catalog` in its tests, which is a rest catalog fixture 
defined in the `conftest.py`, and I think it would be a good place to add this 
test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to