kevinjqliu commented on code in PR #1434:
URL: https://github.com/apache/iceberg-python/pull/1434#discussion_r1887152140
##########
tests/catalog/test_rest.py:
##########
@@ -681,6 +681,51 @@ def test_update_namespace_properties_200(rest_mock:
Mocker) -> None:
assert response == PropertiesUpdateSummary(removed=[], updated=["prop"],
missing=["abc"])
+def test_namespace_exists_200(rest_mock: Mocker) -> None:
+ rest_mock.head(
+ f"{TEST_URI}v1/namespaces/fokko",
+ status_code=200,
+ request_headers=TEST_HEADERS,
+ )
+ catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
+
+ assert catalog.namespace_exists("fokko")
Review Comment:
nit: the tests here are only verifying against the mock response.
it would be great to test against the actual REST catalog in integration
tests.
i noticed that does not exist right now, perhaps we can start a
`tests/integration/test_rest_catalog.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
