feniljain commented on code in PR #800: URL: https://github.com/apache/iceberg-rust/pull/800#discussion_r1885012562
########## crates/iceberg/src/spec/manifest.rs: ########## @@ -1164,8 +1164,8 @@ impl DataFile { &self.upper_bounds } /// Get the Implementation-specific key metadata for the data file. - pub fn key_metadata(&self) -> &[u8] { - &self.key_metadata + pub fn key_metadata(&self) -> Option<&[u8]> { + self.key_metadata.as_ref().map(|x| x as &[u8]) Review Comment: Ahh, I was looking for exactly this, thanks for pointing it out! 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org