Xuanwo commented on code in PR #800:
URL: https://github.com/apache/iceberg-rust/pull/800#discussion_r1884868013
##########
crates/iceberg/src/expr/visitors/expression_evaluator.rs:
##########
@@ -338,7 +338,7 @@ mod tests {
nan_value_counts: HashMap::new(),
lower_bounds: HashMap::new(),
upper_bounds: HashMap::new(),
- key_metadata: vec![],
+ key_metadata: Some(vec![]),
Review Comment:
Do we need to use `None` by default?
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -1134,7 +1134,7 @@ impl DataFile {
&self.upper_bounds
}
/// Get the Implementation-specific key metadata for the data file.
- pub fn key_metadata(&self) -> &[u8] {
+ pub fn key_metadata(&self) -> &Option<Vec<u8>> {
Review Comment:
It's better to return `Option<&[u8]>` to make it easier to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
