aokolnychyi commented on code in PR #11620: URL: https://github.com/apache/iceberg/pull/11620#discussion_r1884367833
########## core/src/main/java/org/apache/iceberg/TableUtil.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +public class TableUtil { + private TableUtil() {} + + /** Returns the format version of the given table */ + public static int formatVersion(Table table) { + Preconditions.checkArgument(null != table, "Invalid table: null"); + + if (table instanceof SerializableTable) { + SerializableTable serializableTable = (SerializableTable) table; + return serializableTable.formatVersion(); + } else if (table instanceof HasTableOperations) { + return ((HasTableOperations) table).operations().current().formatVersion(); Review Comment: Optional: Same comment about an extra variable for `TableOperations`. ########## core/src/main/java/org/apache/iceberg/SerializableTable.java: ########## @@ -158,6 +160,21 @@ public Map<String, String> properties() { return properties; } + public int formatVersion() { + return formatVersion; + } + + private int formatVersion(Table table) { + if (table instanceof HasTableOperations) { + return ((HasTableOperations) table).operations().current().formatVersion(); + } else { + // formatVersion=-1 will never be used/returned, because Review Comment: Optional: We may actually avoid the override by doing something like this below. ``` public int formatVersion() { if (formatVersion == UNKNOWN_FORMAT_VERSION) { throw new UnsupportedOperationException("Format version is unknown"); } return formatVersion; } private int formatVersion(Table table) { if (table instanceof HasTableOperations) { ... } else { return UNKNOWN_FORMAT_VERSION; } } ``` This would also cover cases for regular tables that didn't have `TableOperations` under the hood. ########## core/src/main/java/org/apache/iceberg/SerializableTable.java: ########## @@ -158,6 +160,21 @@ public Map<String, String> properties() { return properties; } + public int formatVersion() { + return formatVersion; + } + + private int formatVersion(Table table) { + if (table instanceof HasTableOperations) { + return ((HasTableOperations) table).operations().current().formatVersion(); Review Comment: Optional: What about an extra variable for `TableOperations`? We have an explicit casts + 3 method invocations, it may be easier to read with code on multiple lines and it would be consistent with the `metadataFileLocation` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
