nastra commented on code in PR #11620: URL: https://github.com/apache/iceberg/pull/11620#discussion_r1853654808
########## core/src/main/java/org/apache/iceberg/TableUtil.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +public class TableUtil { + private TableUtil() {} + + /** + * Returns the format version of the given table. Note that subclasses of {@link + * BaseMetadataTable} do not have a format version. The only exception to this is {@link + * PositionDeletesTable}, where the format version is fetched from the underlying table. + */ + public static int formatVersion(Table table) { + Preconditions.checkArgument(null != table, "Invalid table: null"); + + // being able to read the format version from the PositionDeletesTable is mainly needed in + // SparkPositionDeletesRewrite when determining whether to rewrite V2 position deletes to DVs + if (table instanceof BaseMetadataTable) { Review Comment: I've simplified the checks a bit. I do think it makes sense to have an easy way to fetch the format version from the `PositionDeletesTable`, since it basically translates 1:1 to the underlying table and so the format version of the `PositionDeletesTable` would be the same as the underlying table . The question is whether we add this logic to `TableUtil` or to the calling site(s) and would like to hear what others think here /cc @amogh-jahagirdar @aokolnychyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
