aokolnychyi commented on code in PR #11620:
URL: https://github.com/apache/iceberg/pull/11620#discussion_r1859414335
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -143,6 +143,10 @@ protected Table newTable(TableOperations ops, String
tableName) {
return new BaseTable(ops, tableName);
}
+ public Table underlyingTable() {
Review Comment:
Question: What about capturing the format version as a field in
`SerializableTable`, similar to what we do for the metadata file location? The
problem right now is that calling `lazyTable()` may actually require a request
to load the metadata, which is something we would want to ideally avoid.
Historically, we kept separate fields for what is considered important
information and may be accessed frequently.
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -143,6 +143,10 @@ protected Table newTable(TableOperations ops, String
tableName) {
return new BaseTable(ops, tableName);
}
+ public Table underlyingTable() {
Review Comment:
Question: What about capturing the format version as a field in
`SerializableTable`, similar to what we do for the metadata file location? The
problem right now is that calling `lazyTable()` may actually require a request
to load the metadata, which is something we would want to ideally avoid.
Historically, we kept separate fields for what is considered important
information and might be accessed frequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
