wenym1 commented on PR #760:
URL: https://github.com/apache/iceberg-rust/pull/760#issuecomment-2537946595
> I find that the implementation has some problems now, it will cause
recursive calls endlessly and stack overflow finally.
>
> Reproduce:
>
> ```
> #[tokio::test]
> async fn test_box_writer() {
> let temp_dir = TempDir::new().unwrap();
> let file_io = FileIOBuilder::new_fs_io().build().unwrap();
> let location_gen =
>
MockLocationGenerator::new(temp_dir.path().to_str().unwrap().to_string());
> let file_name_gen =
> DefaultFileNameGenerator::new("test".to_string(), None,
DataFileFormat::Parquet);
>
> let pw = ParquetWriterBuilder::new(
> WriterProperties::builder().build(),
> file_io.clone(),
> location_gen,
> file_name_gen,
> );
> let data_file_builder =
>
DataFileWriterBuilder::new(Arc::new(Schema::builder().build().unwrap()), pw,
None).boxed();
>
> // stack overflow here.
> let mut writer = data_file_builder.build().await.unwrap();
> }
> ```
Thanks for pointing it out. The stack overflow was caused by accidentally
repeatedly interleaving call on the `build` of `IcebergWriterBuilder` and
`DynIcebergWriterBuilder`. Already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
