Xuanwo commented on PR #760: URL: https://github.com/apache/iceberg-rust/pull/760#issuecomment-2540446608
Hi, thank you @wenym1 for your work on this, and thanks to @ZENOTME and @liurenjie1024 for their reviews. I'm a bit concerned about the complexity this PR introduces. > One point you mentioned is the box allocation, do we have measurement of how much this cost is compared with actual IO? Given that users always utilize the dyn-compatible API from outside, I believe the box allocation cannot be avoided. > Personally, I think more important benefits of this PR is to provide extra dyn traits for object safety. I thought `IcebergWriter` was already a dyn-compatible trait, but `IcebergWriterBuilder` is not. Maybe we could work on `IcebergWriterBuilder` directly? Perhaps we could modify it to take `&self` instead of `self`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
