Ppei-Wang commented on code in PR #11729:
URL: https://github.com/apache/iceberg/pull/11729#discussion_r1880074762


##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala:
##########
@@ -65,6 +85,25 @@ case class ResolveViews(spark: SparkSession) extends 
Rule[LogicalPlan] with Look
       if query.resolved && !c.rewritten =>
       val aliased = aliasColumns(query, columnAliases, columnComments)
       c.copy(query = aliased, queryColumnNames = query.schema.fieldNames, 
rewritten = true)
+
+    case s: Sort if conf.orderByOrdinal && s.order.exists(o => 
containIntLiteral(o.child)) =>

Review Comment:
   Thanks for your suggestion, modified. And Could you please help approve 
workflow runs?thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to