nastra commented on code in PR #11729:
URL: https://github.com/apache/iceberg/pull/11729#discussion_r1879874793
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -562,6 +562,64 @@ public void readFromViewWithCTE() throws
NoSuchTableException {
assertThat(sql("SELECT * FROM %s",
viewName)).hasSize(1).containsExactly(row(10, 1L));
}
+ @TestTemplate
+ public void readFromViewWithGroupByOrdinal() throws NoSuchTableException {
+ insertRows(3);
+ insertRows(2);
Review Comment:
not sure why we actually need to first write 3 rows and then 2 rows. I
believe this line can be removed and the result check further below can be
updated to `.containsExactlyInAnyOrder(row(1, 1L), row(2, 1L), row(3, 1L))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
