nastra commented on code in PR #11729:
URL: https://github.com/apache/iceberg/pull/11729#discussion_r1879872034
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -562,6 +562,64 @@ public void readFromViewWithCTE() throws
NoSuchTableException {
assertThat(sql("SELECT * FROM %s",
viewName)).hasSize(1).containsExactly(row(10, 1L));
}
+ @TestTemplate
+ public void readFromViewWithGroupByOrdinal() throws NoSuchTableException {
+ insertRows(3);
+ insertRows(2);
+ String viewName = viewName("viewWithGroupByOrdinal");
+ String sql = String.format("SELECT id, count(1) FROM %s GROUP BY 1",
tableName);
+
+ ViewCatalog viewCatalog = viewCatalog();
+
+ viewCatalog
+ .buildView(TableIdentifier.of(NAMESPACE, viewName))
+ .withQuery("spark", sql)
+ .withDefaultNamespace(NAMESPACE)
+ .withDefaultCatalog(catalogName)
+ .withSchema(schema(sql))
+ .create();
+
+ assertThat(sql("SELECT * FROM %s", viewName))
+ .hasSize(3)
+ .containsExactlyInAnyOrder(row(1, 2L), row(2, 2L), row(3, 1L));
+ }
+
+ @TestTemplate
+ public void readFromViewWithOrderByOrdinal() throws NoSuchTableException {
+ insertRows(10);
+ String viewName = viewName("viewWithOrderByOrdinal");
+ String sql = String.format("SELECT id FROM %s ORDER BY 1", tableName);
+
+ ViewCatalog viewCatalog = viewCatalog();
+
+ viewCatalog
+ .buildView(TableIdentifier.of(NAMESPACE, viewName))
+ .withQuery("spark", sql)
+ .withDefaultNamespace(NAMESPACE)
+ .withDefaultCatalog(catalogName)
+ .withSchema(schema(sql))
+ .create();
+
+ List<Object[]> expected =
+ IntStream.rangeClosed(1,
10).mapToObj(this::row).collect(Collectors.toList());
+
+ assertThat(sql("SELECT * FROM %s", viewName))
+ .hasSize(10)
+ .containsExactlyInAnyOrderElementsOf(expected);
+ }
+
+ @TestTemplate
+ public void createViewWithGroupByOrdinal() throws NoSuchTableException {
Review Comment:
please also add a similar test to the case where `ORDER BY` is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
