zhjwpku commented on code in PR #3: URL: https://github.com/apache/iceberg-cpp/pull/3#discussion_r1869543514
########## cmake_modules/BuildUtils.cmake: ########## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Borrowed the file from Apache Arrow: +# https://github.com/apache/arrow/blob/main/cpp/cmake_modules/BuildUtils.cmake + +function(iceberg_install_cmake_package PACKAGE_NAME EXPORT_NAME) Review Comment: > Not much to add here, as @wgtmac pointed out those are utility functions to help adding new libraries in the future. The ADD_ICEBERG_LIB function is a highly configurable function that simplifies the process of defining, building, and installing both shared and static libraries, along with their associated settings (e.g., include directories, link dependencies, etc.). To be honest if we only plan to build iceberg core and puffin at the moment it might be overkill but I don't think it's harmful to reuse what Arrow has done here. I also think it is overkill, I suggest we stick to modern cmake(which is target oriented) and start from easy, improve as project gets complicate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
