wgtmac commented on code in PR #3: URL: https://github.com/apache/iceberg-cpp/pull/3#discussion_r1867914158
########## cmake_modules/BuildUtils.cmake: ########## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Borrowed the file from Apache Arrow: +# https://github.com/apache/arrow/blob/main/cpp/cmake_modules/BuildUtils.cmake + +function(iceberg_install_cmake_package PACKAGE_NAME EXPORT_NAME) Review Comment: These are boilerplate code to add libraries with essential arguments for includes, linking libraries, and exporting install targets. I copied them from Apache Arrow with simplification. They are super useful if we will add more libraries in the future. In the next step, I will add third-party libraries and these lines will be used so I don't want to delete them for now and add them back in the next patch :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
