gaborkaszab commented on PR #3: URL: https://github.com/apache/iceberg-cpp/pull/3#issuecomment-2519796228
Just a general comment for the future: I don't think all of the active reviewers gave an approve to this PR (I certainly didn't). For me it seemed a bit rushed to merge. There was even open questions there that we haven't closed entirely. E.g. there was a discussion about other build tools than CMake. Even though there seemed to be a preference of CMake we haven't wrapped that discussion up. @Xuanwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
