pvary commented on code in PR #11513: URL: https://github.com/apache/iceberg/pull/11513#discussion_r1852559207
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkRewriteExecutor.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.actions; + +import java.util.Map; +import java.util.Set; +import org.apache.iceberg.ContentFile; +import org.apache.iceberg.ContentScanTask; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Table; +import org.apache.iceberg.actions.FileRewriteExecutor; +import org.apache.iceberg.actions.FileRewriteGroup; +import org.apache.iceberg.actions.FileRewritePlan; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; + +/** + * Common parent for data and positional delete rewrite executors. + * + * @param <I> the Java type of the plan info + * @param <T> the Java type of the tasks to read content files + * @param <F> the Java type of the content files + * @param <G> the Java type of the planned groups + */ +abstract class SparkRewriteExecutor< + I, + T extends ContentScanTask<F>, + F extends ContentFile<F>, + G extends FileRewriteGroup<I, T, F>> + implements FileRewriteExecutor<I, T, F, G> { + private final Table table; + private long writeMaxFileSize; + private int outputSpecId; + + SparkRewriteExecutor(Table table) { + this.table = table; + } + + Table table() { + return table; + } + + long writeMaxFileSize() { + return writeMaxFileSize; + } + + int outputSpecId() { + return outputSpecId; + } + + PartitionSpec outputSpec() { + return table.specs().get(outputSpecId); + } + + @Override + public void initPlan(FileRewritePlan<I, T, F, G> plan) { Review Comment: If we are fairly confident, that only `writeMaxFileSize` and `outputSpecId` comes from the plan, then we can add `setWriteMaxFileSize` and `setOutputSpecId` to the `FileRewriteExecutor` API instead of the `initPlan(FileRewritePlan)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
