aokolnychyi commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1851129804


##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -69,6 +70,7 @@ public String partition() {
   private final Map<Integer, PartitionSpec> specsById;
   private final PartitionSet deleteFilePartitions;
   private final Set<F> deleteFiles = newFileSet();
+  private final Set<String> manifestsReferencedForDeletes = Sets.newHashSet();

Review Comment:
   Any shorter names like `manifestsWithDeletes` or `deleteFileManifests`?
   A few calls below split into multiple lines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to