aokolnychyi commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1849242654
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -185,6 +198,16 @@ List<ManifestFile> filterManifests(Schema tableSchema,
List<ManifestFile> manife
return ImmutableList.of();
}
+ // Use the current set of referenced manifests as a source of truth when
it's a subset of all
+ // manifests and all removals which were performed reference manifests.
+ // If a manifest is not in the trusted referenced set, filtering can be
skipped
+ // assuming that the manifest does not have any live entries or aged out
deletes
+ Set<String> manifestLocations =
+ manifests.stream().map(ManifestFile::path).collect(Collectors.toSet());
+ boolean trustReferencedManifests =
Review Comment:
Spotless formats this in a weird way. I wonder if we can play around with
the names to stay on 1 line and/or potentially add a helper method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
