amogh-jahagirdar commented on code in PR #11561:
URL: https://github.com/apache/iceberg/pull/11561#discussion_r1850541469
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -267,31 +271,47 @@ private Dataset<Row> toDS(String schema, String jsonData)
{
}
protected void validateDelete(
- Snapshot snapshot, String changedPartitionCount, String
deletedDataFiles) {
- validateSnapshot(snapshot, DELETE, changedPartitionCount,
deletedDataFiles, null, null);
+ int formatVersion, Snapshot snapshot, String changedPartitionCount,
String deletedDataFiles) {
+ validateSnapshot(
+ formatVersion, snapshot, DELETE, changedPartitionCount,
deletedDataFiles, null, null);
Review Comment:
Yeah after writing this all out, I think so. I originally wanted to avoid an
exploding number of tests that could be caused by parameterizing the tests but
after seeing which tests explicitly we should skip becaujse they're not
relevant for DVs, we can parameterize the format and just add assume calls for
those tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
