nastra commented on code in PR #11561:
URL: https://github.com/apache/iceberg/pull/11561#discussion_r1849847923
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java:
##########
@@ -267,31 +271,47 @@ private Dataset<Row> toDS(String schema, String jsonData)
{
}
protected void validateDelete(
- Snapshot snapshot, String changedPartitionCount, String
deletedDataFiles) {
- validateSnapshot(snapshot, DELETE, changedPartitionCount,
deletedDataFiles, null, null);
+ int formatVersion, Snapshot snapshot, String changedPartitionCount,
String deletedDataFiles) {
+ validateSnapshot(
+ formatVersion, snapshot, DELETE, changedPartitionCount,
deletedDataFiles, null, null);
Review Comment:
rather than passing around the format version, would it make sense to
parameterize `SparkRowLevelOperationsTestBase` and add `formatVersion` as
another parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
