huaxingao commented on code in PR #11520:
URL: https://github.com/apache/iceberg/pull/11520#discussion_r1844353250
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -541,7 +550,19 @@ private static NullabilityHolder newNullabilityHolder(int
size) {
@Override
public void setRowGroupInfo(
PageReadStore source, Map<ColumnPath, ColumnChunkMetaData> metadata,
long rowPosition) {
- this.rowStart = rowPosition;
+ setRowGroupInfo(source, metadata);
+ }
+
+ @Override
+ public void setRowGroupInfo(
+ PageReadStore source, Map<ColumnPath, ColumnChunkMetaData> metadata) {
+ this.rowStart =
+ source
+ .getRowIndexOffset()
+ .orElseThrow(
+ () ->
+ new IllegalArgumentException(
Review Comment:
nit: Is there a better Exception than `IllegalArgumentException`? Is
`IllegalStateException` a bit better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
