wypoon commented on code in PR #11520: URL: https://github.com/apache/iceberg/pull/11520#discussion_r1838526411
########## parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReader.java: ########## @@ -28,5 +28,14 @@ public interface ParquetValueReader<T> { List<TripleIterator<?>> columns(); + /** + * @deprecated since 1.6.0, will be removed in 1.7.0; use setPageSource(PageReadStore) instead. Review Comment: In my change, I put down 1.9.0. If there is no 1.9.0, and the methods are removed in 2.0.0 instead, I don't think that would be a problem. On the other hand, we don't want to give the impression that the methods could still exist in a 1.9.0 and might be removed in 2.0.0 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org