huaxingao commented on code in PR #11520:
URL: https://github.com/apache/iceberg/pull/11520#discussion_r1841100645
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:
##########
@@ -55,8 +55,14 @@ public ColumnarBatchReader(List<VectorizedReader<?>>
readers) {
@Override
public void setRowGroupInfo(
PageReadStore pageStore, Map<ColumnPath, ColumnChunkMetaData> metaData,
long rowPosition) {
- super.setRowGroupInfo(pageStore, metaData, rowPosition);
- this.rowStartPosInBatch = rowPosition;
+ setRowGroupInfo(pageStore, metaData);
+ }
+
+ @Override
+ public void setRowGroupInfo(
+ PageReadStore pageStore, Map<ColumnPath, ColumnChunkMetaData> metaData) {
+ super.setRowGroupInfo(pageStore, metaData);
+ this.rowStartPosInBatch = pageStore.getRowIndexOffset().orElse(0L);
Review Comment:
if `pageStore.getRowIndexOffset()` is empty, does it mean
[getRowIndexOffset()](https://github.com/apache/parquet-java/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java#L379)
returns a negative value? Shall we throw Exception instead of default it to 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
