nastra commented on code in PR #11538:
URL: https://github.com/apache/iceberg/pull/11538#discussion_r1841692014
##########
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##########
@@ -82,12 +83,15 @@ public abstract class DeleteReadTests {
@Parameter protected FileFormat format;
+ @Parameter(index = 1)
+ protected int formatVersion;
+
@Parameters(name = "fileFormat = {0}")
public static Object[][] parameters() {
return new Object[][] {
- new Object[] {FileFormat.PARQUET},
- new Object[] {FileFormat.AVRO},
- new Object[] {FileFormat.ORC}
+ new Object[] {FileFormat.PARQUET, 2},
+ new Object[] {FileFormat.AVRO, 2},
+ new Object[] {FileFormat.ORC, 2}
Review Comment:
yep we should, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
