RussellSpitzer commented on code in PR #11419:
URL: https://github.com/apache/iceberg/pull/11419#discussion_r1840549260
##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -180,6 +180,17 @@ private void updateColumn(Types.NestedField field,
Types.NestedField existingFie
}
}
+ private boolean compatibleType(Type newType, Type existingType) {
+ if (existingType.isPrimitiveType()) {
+ // Primitive -> Wider Primitive
+ return newType.isPrimitiveType()
+ && TypeUtil.isPromotionAllowed(newType,
existingType.asPrimitiveType());
Review Comment:
This is all my fault since I wrote those names in my suggestion in the first
place, sorry for churn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
